neurobagel / federation-api

REST API for query federation over multiple Neurobagel graph databases
https://federate.neurobagel.org
MIT License
0 stars 0 forks source link

Check for equivalence of term labels for duplicate TermURLs across nodes #68

Open alyssadai opened 9 months ago

alyssadai commented 9 months ago

https://github.com/neurobagel/federation-api/blob/9d685dba8518c813a3c4a6f222c59cdc7264700e/app/api/crud.py#L163-L165

If we overwrite previous instances here, would it be reasonable to check first if the term is the same as the one we've already stored? If we ever encounter a situation where some jokester has a neurobagel node where they just make up their own TermURLs for our terms, we could end up with a tricky to debug situation if all that determines what we return here is the order in which we unpack the responses from nodes.

_Originally posted by @surchs in https://github.com/neurobagel/federation-api/pull/65#discussion_r1473585396_

surchs commented 8 months ago

I would vote to bump this from the backlog and give it a someday label instead - this is a yet-to-be-encountered problem. We should address it, but we have more pressing things to do at the moment I think

alyssadai commented 8 months ago

Sure, that sounds okay to me.

github-actions[bot] commented 5 months ago

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days. We have applied the _flag:stale label to indicate that this issue should be reviewed again. When you review, please reread the spec and then apply one of these three options: