Open alyssadai opened 9 months ago
I would vote to bump this from the backlog and give it a someday
label instead - this is a yet-to-be-encountered problem. We should address it, but we have more pressing things to do at the moment I think
Sure, that sounds okay to me.
We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale
label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:
flag:schedule
label to suggest moving this issue into the backlog nowsomeday
label to show that this won't be prioritized. The stalebot will ignore issues with this
label in the future. Use sparingly!
https://github.com/neurobagel/federation-api/blob/9d685dba8518c813a3c4a6f222c59cdc7264700e/app/api/crud.py#L163-L165
If we overwrite previous instances here, would it be reasonable to check first if the term is the same as the one we've already stored? If we ever encounter a situation where some jokester has a neurobagel node where they just make up their own TermURLs for our terms, we could end up with a tricky to debug situation if all that determines what we return here is the order in which we unpack the responses from nodes.
_Originally posted by @surchs in https://github.com/neurobagel/federation-api/pull/65#discussion_r1473585396_