search

neurodata / SPORF

This is the implementation of Sparse Projection Oblique Randomer Forest
https://neurodata.io/forests/
97 stars 46 forks source link

fix string -> int #336

Open MrAE opened 5 years ago

netlify[bot] commented 5 years ago

Deploy preview for rerf ready!

Built with commit aa4f5a1e1b54b6361272dfdece7a9e51bb993b70

https://deploy-preview-336--rerf.netlify.com

falkben commented 5 years ago

why did run time go up?

MrAE commented 5 years ago

The labels were strings. Not sure if it was running properly the first time.

falkben commented 5 years ago

pybind11 may have been doing the conversion for us, but agree, this is better. but even better than this would be validation in the class itself to ensure that the class labels are integers, or to just convert them there.

On Wed, Oct 2, 2019 at 3:03 PM Jesse Leigh Patsolic < notifications@github.com> wrote:

The labels were strings. Not sure if it was running properly the first time.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/neurodata/SPORF/pull/336?email_source=notifications&email_token=AAE7NZ6VIAIN254QLYHEYXDQMTWAXA5CNFSM4I4ZJ4G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAF2P4A#issuecomment-537634800, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE7NZ3VOKMWNFBLRJXZYLDQMTWAXANCNFSM4I4ZJ4GQ .