neurospin / pylearn-parsimony

Structured Machine Learning in Python
BSD 3-Clause "New" or "Revised" License
45 stars 16 forks source link

helper to generate linear operator refactoring #9

Closed duchesnay closed 9 years ago

duchesnay commented 9 years ago

1) Harmonize linear operator construction helper: some helper return A, some return A, n_compact. Proposition all helper return only A

2) linear operator is actually a simple list. We would like to:

I propose to create an object LinearOperator which is a list (inherits from a list) this way it will not impact the code. I propose to add, at least, 3 methods:

Question should we move from helper to statics constructors ?

tomlof commented 9 years ago

I totally agree with 1.

Point 2 seems like a good idea! Two comments:

duchesnay commented 9 years ago

Totally agree with both comments, I am working on it

duchesnay commented 9 years ago

Point 1: harmonization is done commit: 0aebc160d5978d0d6637cef2a42278281beb16f6 Now working on point 2

tomlof commented 9 years ago

Perfect!

duchesnay commented 9 years ago

Done