neurostuff / neurostore

The NeuroStore/Neurosynth application
https://compose.neurosynth.org
9 stars 6 forks source link

ENH: Add custom tsquery from websearch function and related tests #838

Closed adelavega closed 2 weeks ago

adelavega commented 1 month ago

Added custom function to parse websearches as in a "quasI" pubmed like format.

The custom parser does the following:

Needs additional testing to ensure behavior is as expected. I added a few queries, but more would be helpful. Could have undefined behavior if invalid combination of parens and quotes are used, but to be fair this is just an invalid queries.

Needed from API side:

@jdkent can you take this and run with it?

adelavega commented 3 weeks ago

Should we disallow special characters in quotes? "Autism Spectrum Disorder (ASD)" --- add to test case

adelavega commented 3 weeks ago

"pre-diagnosis" - can we get a document that has this term in it.

currently: "pre-diagnosis" compiles to PRE<->DIAGNOSIS

should it be "PRE-DIAGNOSIS" instead?

jdkent commented 3 weeks ago

currently: "pre-diagnosis" compiles to PRE<->DIAGNOSIS should it be "PRE-DIAGNOSIS" instead?

testing the db, both queries gave the same result, so it's safe to replace the hyphen with <->

adelavega commented 3 weeks ago

noice

adelavega commented 2 weeks ago

What do we have left to do here?

adelavega commented 2 weeks ago

Awesome! So for deployment I think we need to make some frontend and documentation changes so users know what's going on @nicoalee

Although, IIRC basic searches should operate very similarly, correct?