neutronX / django-markdownx

Comprehensive Markdown plugin built for Django
https://neutronx.github.io/django-markdownx/
Other
863 stars 153 forks source link

Please remove pip from requirements.txt #146

Closed aaugustin closed 4 years ago

aaugustin commented 5 years ago

Having pip in requirements.txt is causing an extra copy of pip to be installed in a virtualenv, while I already have it at the system level. This adds 8,4MB to the size of a container image I'm building for no good reason. Most likely anyone who's able to use requirements.txt already has pip installed so it should be safe to remove it.

adi- commented 5 years ago

Good point. Will be removed in next version.

2w3 commented 5 years ago

I was remove pip at requirements.txt and sent PR by this Issue.

https://github.com/neutronX/django-markdownx/pull/148

adi- commented 4 years ago

Already in master