new-frontiers-14 / frontier-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
GNU Affero General Public License v3.0
88 stars 535 forks source link

Canisters update #2412

Closed dvir001 closed 1 week ago

dvir001 commented 1 week ago

About the PR

Canisters now worth selling for base price of 1000 Canisters price in cargo up by 1000 Removed carbon canister from cargo Fixed the canister spawner to have all of them in it. Ship prices adjusted.

Why / Balance

Give canisters a base worth for selling them.

How to test

N/A

Media

N/A

Requirements

Breaking changes

Ship prices should go up, but sell will balance it out back.

Changelog :cl:

dvir001 commented 1 week ago

Waiting for ship price test to make changes, had to resave McCargo to force it to run.

whatston3 commented 1 week ago

If this is going through, should really consider putting #2330 in.

dvir001 commented 1 week ago

Frick

Error Message:
     Arbitrage possible on Stasis. Minimal price should be 55293.632623762416, 4.999995% over the appraise price (52660.6048903007).
Assert.That(vessel.Price, Is.AtLeast(idealMinPrice))
  Expected: greater than or equal to 55293.6326237624[16](https://github.com/new-frontiers-14/frontier-station-14/actions/runs/11872499574/job/33086278004?pr=2412#step:9:17)d
  But was:  55000
dustylens commented 1 week ago

:(

whatston3 commented 1 week ago

Had a thought, just noting it here:

If you wanted to keep existing values the same, but increase values for salvaged canisters, you could make a distinction between new cans, equipped on ships and bought from cargo (thinner, crappy construction, cheaper to buy) and older cans found on salvage (beefier construction, higher max pressure?, higher value).

However: how would you differentiate the two visually, if at all?

dvir001 commented 1 week ago

Had a thought, just noting it here:

If you wanted to keep existing values the same, but increase values for salvaged canisters, you could make a distinction between new cans, equipped on ships and bought from cargo (thinner, crappy construction, cheaper to buy) and older cans found on salvage (beefier construction, higher max pressure?, higher value).

However: how would you differentiate the two visually, if at all?

Just leave them all the same im not getting bullied again for small canisters :(

dvir001 commented 1 week ago

This is good to go, if we merge this consider also the 30k start change.

dvir001 commented 1 week ago

Going to merge this before the gas changes, later today.

dvir001 commented 1 week ago

Ok going to merge this, this will break some new ships pricing but nothing crazy to fix.