new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
459 stars 135 forks source link

Insert XKit button before crabs, etc #2125

Closed marcustyphoon closed 1 year ago

marcustyphoon commented 1 year ago

There are about a million ways to do this, as I'm sure you have seen from my various PRs.

In the vertical nav layout, this adjusts the XKit button to be inserted in between the primary set of navigation items (that it looks like) and anything else in the left navigation element. If the selector it relies on is removed, it will fall back to inserting the button at the very end of the nav element.

This is still potentially prone to inconsistency:

oh fun effect: if I put the xkit button right after the settings menu (where it would go if tumblr moved the tumblrmart button elsewhere and a user had no optional buttons), then resize around the 1162px breakpoint, some of the menus get destroyed and reattached and the xkit button winds up above account

so to make it totally consistent, either one has to rely on at least the tumblrmart button still existing and being the same in all non-mobile breakpoints, or one has to properly style the button to not look weird inline and then put it before account where it used to be

But hopefully(?) this does something semi-reasonable in most possible breakage scenarios.

nightpool commented 1 year ago

as we discussed on discord there's enough layout inconsistencies that we should probably just leave it as is for now