new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
459 stars 135 forks source link

Add .xpi download script #2154

Closed marcustyphoon closed 21 hours ago

marcustyphoon commented 1 week ago

Creates a script that, given proper credentials, downloads the latest signed .xpi off addons.mozilla.org, since I don't think we can totally rely on web-ext sign returning it in CI. (Whatever the maximum timeout on a github action is, XKit Rewritten regularly has approvals that take a week, and it definitely isn't that.)

Uses .env for secrets, at the moment; I don't know offhand how to isomorphically grab secrets on a developer's machine and in Github Actions, but I can probably figure it out. Ah, didn't require any changes; cool.

(I can't remember off the top of my head where I read a whole thread of developers discussing how to do build automation for this project, but I definitely remember reading one, and I'd like to it if I did. Anyway, it seems potentially sort of kind of possible to do it entirely within Github Actions; this is a step in investigating that.)

marcustyphoon commented 21 hours ago

Included in #2155.