It has come to my attention that the contents of the XKit Patches per-version patch functions are supposed to be moved into xkit.js itself when the extension is updated. It makes particular sense to do this when moving to a packaged extension, as there's no need to use this patch behavior at all after that transition; changes can be made to xkit.js directly. (Users can still in theory use the xkit editor to add patches, of course.) This thus:
Copies the entire v7.9.2 patch function into xkit.js. For review simplicity, this is a direct copy rather than merging the patches into the object. I did check, and the patches should have no side effects (they're all adjustments to the XKit object, mostly added methods), so it shouldn't matter that this occurs earlier in the boot process. (The code in the body of the XKit Patches run function does have side effects; this PR does not touch it.)
Improves the run_order logic a bit, such that versions not contained in the run_order array simply have no patches applied and it does not need to be updated for future releases (resolves note in #2163). This needs to be copied to the v7.9.2 branch in place of https://github.com/new-xkit/XKit/commit/9a32d0cf1b4ee87dd47f9922889d48ab695075f8, in which I crashed XKit; fun times.
Note that this could delete the v7.9.2 patches entirely, on the basis that this version of XKit Patches will only be shipped with v7.10.0 and above, but that would cause crashes when downgrading (particularly annoying for development).
It has come to my attention that the contents of the XKit Patches per-version patch functions are supposed to be moved into xkit.js itself when the extension is updated. It makes particular sense to do this when moving to a packaged extension, as there's no need to use this patch behavior at all after that transition; changes can be made to xkit.js directly. (Users can still in theory use the xkit editor to add patches, of course.) This thus:
XKitobject, mostly added methods), so it shouldn't matter that this occurs earlier in the boot process. (The code in the body of the XKit Patches run function does have side effects; this PR does not touch it.)run_orderlogic a bit, such that versions not contained in therun_orderarray simply have no patches applied and it does not need to be updated for future releases (resolves note in #2163). This needs to be copied to the v7.9.2 branch in place of https://github.com/new-xkit/XKit/commit/9a32d0cf1b4ee87dd47f9922889d48ab695075f8, in which I crashed XKit; fun times.Note that this could delete the v7.9.2 patches entirely, on the basis that this version of XKit Patches will only be shipped with v7.10.0 and above, but that would cause crashes when downgrading (particularly annoying for development).