newfold-labs / wp-module-ecommerce

Next-generation eCommerce Experience for WordPress sites at Newfold Digital.
GNU General Public License v2.0
10 stars 4 forks source link

configure tax settings fetching from settings api #253

Closed ramyakrishnai closed 8 months ago

ramyakrishnai commented 8 months ago

Proposed changes

Getting the configure tax settings value from settings api as woocommerce has made changes to their tasks rest api which is no more returning the set up tasks

Before in the api response of onboarding-tasks , we're getting this response

Screenshot 2024-03-20 at 5 15 08 PM

Current version of woocommerce (8.7.0) are passing empty array.

Screenshot 2024-03-20 at 5 15 23 PM

So, we're using settings api based on woocommerce_calc_taxes

Screenshot 2024-03-20 at 5 20 33 PM

Type of Change

Checklist

Further comments

aratidgr8 commented 8 months ago

@ramyakrishnai Can you add earlier & current response for better understanding of change

ramyakrishnai commented 8 months ago

@ramyakrishnai Can you add earlier & current response for better understanding of change

Done, added in description

aratidgr8 commented 8 months ago

@ramyakrishnai Hope this API response change is brands agnostic?

ramyakrishnai commented 8 months ago

@ramyakrishnai Hope this API response change is brands agnostic? Yes