search

newrelic / go-agent

New Relic Go Agent
Apache License 2.0
762 stars 294 forks source link

Added Attribute Support for ZeroLog #935

Open mirackara opened 1 month ago

mirackara commented 1 month ago

Links

Details

iamemilio commented 1 week ago

I think this will work with simple attributes like strings or numbers, but what about maps, or slices? I think that is a weakness of this library in general. It needs to be able to parse a lot of complex objects, and the token that seperates them is configurable in zerolog. See my risk matrix item for more info. Before we spend more time here, I might recommend another re-write.

nr-swilloughby commented 1 week ago

I think this will work with simple attributes like strings or numbers, but what about maps, or slices? I think that is a weakness of this library in general. It needs to be able to parse a lot of complex objects, and the token that seperates them is configurable in zerolog. See my risk matrix item for more info. Before we spend more time here, I might recommend another re-write.

I agree. This is definitely a concern about the library.