search

newrelic / go-agent

New Relic Go Agent
Apache License 2.0
775 stars 295 forks source link

Remove special handling of panic(nil) #985

Open nr-swilloughby opened 2 weeks ago

nr-swilloughby commented 2 weeks ago

Fixes issue 975 by removing the special handling that was wrapped around instrumented functions that experience a panic(nil). Previously the code sought to keep the pre-Go-1.21 behavior of not propagating nil panics, but a better approach is to not treat them any differently than other panics.

iamemilio commented 1 week ago

I like that the new test cover's checking that a panic still occurs in the environment. LTGM