search

newrelic / newrelic-java-agent

The New Relic Java agent
Apache License 2.0
202 stars 144 forks source link

Use recordResponseTimeMetric instead recordMetric in NewRelic agent API layer #2132

Closed jtduffy closed 2 weeks ago

jtduffy commented 2 weeks ago

Test run PR of #2128 from @matzz

com.newrelic.api.agent.NewRelic::recordResponseTimeMetric is calling the wrong method on the metricAggregator instance:

    public static void recordResponseTimeMetric(String name, long millis) {
        getAgent().getMetricAggregator().recordMetric(name, millis);
    }
codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.71%. Comparing base (d1111df) to head (4674860). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2132 +/- ## ============================================ + Coverage 70.69% 70.71% +0.01% - Complexity 9983 9985 +2 ============================================ Files 841 841 Lines 40289 40290 +1 Branches 6107 6107 ============================================ + Hits 28484 28492 +8 + Misses 9062 9053 -9 - Partials 2743 2745 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.