newrelic / newrelic-ruby-agent

New Relic RPM Ruby Agent
https://docs.newrelic.com/docs/apm/agents/ruby-agent/getting-started/introduction-new-relic-ruby/
Apache License 2.0
1.2k stars 597 forks source link

Investigate: Simplecov branch coverage drop #2309

Open hannahramadan opened 11 months ago

hannahramadan commented 11 months ago

Simplecov branch coverage dropped from above 85% to just ~82% with no clear cause.

https://github.com/newrelic/newrelic-ruby-agent/pull/2305 was over the threshold and https://github.com/newrelic/newrelic-ruby-agent/pull/2306 was lower, so its possible the change has to do with 2306.

PR#2308 lowered the threshold to get the CI working again. Once the cause is identified and fixed, the threshold should be raised.

Update: Code coverage fell once again. We've lowered the threshold to unblock PRs.

workato-integration[bot] commented 11 months ago

https://new-relic.atlassian.net/browse/NR-175976