newrelic / node-native-metrics

Optional native module for collecting low-level Node & V8 metrics
Apache License 2.0
63 stars 41 forks source link

chore: Refactor to bundling prebuilds with prebuildify #237

Closed jsumners-nr closed 9 months ago

jsumners-nr commented 9 months ago

WIP

Proposed Release Notes

Links

Details

codecov[bot] commented 9 months ago

Codecov Report

Attention: Patch coverage is 1.61290% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 73.36%. Comparing base (02f7bce) to head (b840740).

:exclamation: Current head b840740 differs from pull request most recent head 5dcb8f7. Consider uploading reports for the commit 5dcb8f7 to get more accurate results

Files Patch % Lines
build.js 0.00% 61 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #237 +/- ## =========================================== - Coverage 97.67% 73.36% -24.32% =========================================== Files 5 2 -3 Lines 644 244 -400 =========================================== - Hits 629 179 -450 - Misses 15 65 +50 ``` | [Flag](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | Coverage Δ | | |---|---|---| | [integration-tests-16-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `63.93% <1.61%> (?)` | | | [integration-tests-16-windows-2019-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `63.93% <1.61%> (?)` | | | [integration-tests-16-windows-2019-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `63.93% <1.61%> (?)` | | | [integration-tests-16-windows-latest-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `63.93% <1.61%> (?)` | | | [integration-tests-16.x-linux](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [integration-tests-16.x-windows-2019](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [integration-tests-16.x-windows-latest](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [integration-tests-18-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `63.11% <1.61%> (?)` | | | [integration-tests-18-windows-2019-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `63.11% <1.61%> (?)` | | | [integration-tests-18-windows-2019-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `63.11% <1.61%> (?)` | | | [integration-tests-18-windows-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `63.11% <1.61%> (?)` | | | [integration-tests-18.x-linux](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [integration-tests-18.x-windows-2019](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [integration-tests-18.x-windows-latest](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [integration-tests-20-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `63.11% <1.61%> (?)` | | | [integration-tests-20-windows-2019-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `63.11% <1.61%> (?)` | | | [integration-tests-20.x-linux](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [integration-tests-20.x-windows-2019](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [integration-tests-20.x-windows-latest](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [unit-tests-16-macos-14-arm64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `70.08% <1.61%> (?)` | | | [unit-tests-16-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `70.08% <1.61%> (?)` | | | [unit-tests-16-windows-2019-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `70.08% <1.61%> (?)` | | | [unit-tests-16-windows-2019-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `70.08% <1.61%> (?)` | | | [unit-tests-16-windows-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `70.08% <1.61%> (?)` | | | [unit-tests-16-windows-latest-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `70.08% <1.61%> (?)` | | | [unit-tests-16.x-linux](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [unit-tests-16.x-windows-2019](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [unit-tests-16.x-windows-latest](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [unit-tests-18-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `69.26% <1.61%> (?)` | | | [unit-tests-18-windows-2019-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `69.26% <1.61%> (?)` | | | [unit-tests-18-windows-2019-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `69.26% <1.61%> (?)` | | | [unit-tests-18-windows-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `69.26% <1.61%> (?)` | | | [unit-tests-18.x-linux](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [unit-tests-18.x-windows-2019](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [unit-tests-18.x-windows-latest](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [unit-tests-20-macos-14-arm64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `69.26% <1.61%> (?)` | | | [unit-tests-20-ubuntu-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `69.26% <1.61%> (?)` | | | [unit-tests-20-windows-2019-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `69.26% <1.61%> (?)` | | | [unit-tests-20-windows-2019-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `69.26% <1.61%> (?)` | | | [unit-tests-20-windows-latest-x64](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `69.26% <1.61%> (?)` | | | [unit-tests-20-windows-latest-x86](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `69.26% <1.61%> (?)` | | | [unit-tests-20.x-linux](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [unit-tests-20.x-windows-2019](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | | [unit-tests-20.x-windows-latest](https://app.codecov.io/gh/newrelic/node-native-metrics/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bizob2828 commented 9 months ago

@jsumners-nr this can be closed correct?

jsumners-nr commented 9 months ago

Yep. Thanks for bringing it to my attention.