search

newrelic / nr1-pathpoint

Pathpoint is an enterprise platform tracker that models system health in relation to actual user-impacting business stages.
Apache License 2.0
8 stars 19 forks source link

GUI editor mangling the measure_time in some cases #51

Closed portoren closed 1 year ago

portoren commented 1 year ago

Description

When a time window other than the Time-Picker default is selected, for example, "60 minutes ago", all touchpoints that did not have measure_time are temporarily calculated from the Time-Picker selection (SINCE 1668428490 UNTIL 1668428790). This change becomes permanent if the Touchpoints GUI editor is opened and the “Save Update” button is clicked.

Steps to Reproduce

  1. To verify the Touchpoints GUI editor before making changes in the Time-Picker.

image

  1. Change the selection in the Time-Picker to 30 minutes:

image

  1. The touchpoint graphic editor opens and clicks on the “Save Update” button.

  2. The Pathpoint is reloaded with the Time-Picker in its default selection and the graphical editor of touchpoints is opened. It is evident that all the touchpoints that did not have a custom measure_time have been modified:

image

  1. Likewise, the touchpoints that have the custom measure_time are not affected by the action of the GUI editor:

image

Expected Behaviour

Touchpoints GUI editor should not save changes in measure_time with Time-Picker effects.

Relevant Logs / Console output

Your Environment

Additional context

JimHagan commented 1 year ago

Thanks for the submission @portoren I saw this issue occur in a customer account. Glad you are able to track it down. This is related but not identical #52

Here is how we are going to handle this...

  1. We want to NEVER save an absolute time window (one with a SINCE AND an UNTIL clause) -- We should raise an error if that is attempted.

  2. We will consider renaming the five minutes ago entry in the time picker to simply say "NOW". This will mean that the time picker will always be setting the point in time. Then the measure_time will be a lookback form the point in time.

  3. NOTE let's consider raising an error if the user tries to:

    • load a JSON file with a touchpoint using an UNTIL clause.
    • load a JSON file missing an ago statement We should disallow these

  4. Let's also consider putting a label above the time picker such as "reference point in time"

FYI @Sandeep10parmar

JimHagan commented 1 year ago

Please also add the "version found in" in the report.

JimHagan commented 1 year ago

@portoren Any more estimate on how long it may take to work on this?

nr-opensource-bot commented 1 year ago

:tada: This issue has been resolved in version 1.7.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: