search

newrelic / nr1-pathpoint

Pathpoint is an enterprise platform tracker that models system health in relation to actual user-impacting business stages.
Apache License 2.0
8 stars 19 forks source link

Removing dashboard link from touchpoint breaks resulting json export #62

Open mantraAppf opened 1 year ago

mantraAppf commented 1 year ago

Description

It is possible to remove the dashboard link from any touchpoint within the Touchbpoints Editor. This results in an invalid json export:

"dashboard_url": false,

which leads to the following error when trying to upload:

The stage 'LOGIN', in touchpoint 'Login Infra (WORKLOAD)', the property 'dashboard_url', should be array

Steps to Reproduce

  1. Open any dashboard with a touchpoint
  2. Click on Touchpoints Editor
  3. Select General
  4. Remove Dashboard Link
  5. Click Save Update
  6. Click Json Configuration
  7. Download json file
  8. Enter description and note (to upload again)
  9. Select json file from step 7
  10. Click upload

Expected Behaviour

Successful upload from previously exported json

Relevant Logs / Console output

The stage 'LOGIN', in touchpoint 'Login Infra (WORKLOAD)', the property 'dashboard_url', should be array

Your Environment

Pathpoint version v.1.7.6

rsamanez commented 1 year ago

Solving Time: 3hours

mantraAppf commented 1 year ago

Hey @rsamanez, thank you for working on this issue, I tried to see how the issue was resolved but could not find the corresponding PR. Would you mind linking it here for future reference? thank you!

JimHagan commented 1 year ago

@rsamanez Did you do a PR for this?

Also @mantraAppf what happens if you put an empty string like ""???

FYI @Sandeep10parmar

JimHagan commented 1 year ago

As a short term workaround perhaps put a link to the Pathpoint instance itself (not ideal)