newrelic / nr1-pathpoint

Pathpoint is an enterprise platform tracker that models system health in relation to actual user-impacting business stages.
Apache License 2.0
8 stars 19 forks source link

Fixing a Bug where you change a STEP LEVEL IN THE StepsEditor #82

Closed rsamanez closed 5 months ago

rsamanez commented 6 months ago

Description

The error was found in the file /components/Modal/StepsEditor.js
in the function: HandleOnChange.

Original function

  HandleOnChange = (target, value, id) => {
    this.setState(
      state => {
        const form = { ...state.form };
        form[`step_${id}`][target] = value;
        const stages = this.UpdateSubSteps(value, id);
        return {
          form,
          stages
        };
      },
      () => {
        if (target === 'substeps') {
          this.ChangeSubsteps(id, value);
        }
      }
    );
    if (target === 'level') {
      this.ChangeOrder(id, value);
    }
  };

Solution

  HandleOnChange = (target, value, id) => {
    if (target === 'substeps') {
      this.setState(
        state => {
          const form = { ...state.form };
          form[`step_${id}`][target] = value;
          const stages = this.UpdateSubSteps(value, id);
          return {
            form,
            stages
          };
        },
        () => {
          this.ChangeSubsteps(id, value);
        }
      );
    }
    if (target === 'level') {
      this.ChangeOrder(id, value);
    }
  };