fix(NcRichText): async import remark-gfm library - Githubissues

nextcloud-libraries / nextcloud-vue

🍱 Vue.js components for Nextcloud app development ✌ https://npmjs.org/@nextcloud/vue

https://nextcloud-vue-components.netlify.app/

Other

217 stars 89 forks source link

fix(NcRichText): async import remark-gfm library #6259

Open Antreesy opened 1 week ago

Antreesy commented 1 week ago

☑️ Resolves

Fix #6246
remark-gfm is 39.5 kB in dev build, which is 30% of rehype-highlight library size (111kB which we're also importing async)
rehype-highlight won't be imported for code blocks without language provided/recognised
⚠️ if all conditions are met, that would cause two re-renders of the first component

🖼️ Screenshots

No visual changes

🏁 Checklist

[x] ⛑️ Tests are included or are not applicable
[x] 📘 Component documentation has been extended, updated or is not applicable
[ ] 3️⃣ Backport to next requested with a Vue 3 upgrade Signed-off-by: Maksim Sukharev antreesy.web@gmail.com