search

nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.16k stars 1.75k forks source link

Insufficient space to copy files when "keep files in source folder" is selected. #5592

Open AlexVerrico opened 4 years ago

AlexVerrico commented 4 years ago

Steps to reproduce

  1. Open the Nextcloud Android app
  2. Choose file(s) to upload, that in total are greater in size than the remaining free space on the device
  3. Select "Keep file in source folder"
  4. Tap upload

Expected behaviour

Because I have selected to keep the files in the source folder, it should not matter that I have selected, for example, 2GB of files, when I have 1GB of free space on my device.

Actual behaviour

The app displays an alert that there is insufficient space to copy the files to the Nextcloud folder, and asks if you would like to move the files instead of copying them

Environment data

Android version: Android 10, security patch level 6 October 2019

Device model: Google Pixel

Stock or customized system: stock, un-rooted Android.

Nextcloud app version: 3.10.1

Nextcloud server version: 18.0.1

Logs

Web server error log

N/A

Nextcloud log (data/nextcloud.log)

N/A

Issue #4465 is pretty much identical, but was closed due to been inactive for a month, without receiving an answer.

If this is a setting that I need to change in the app or on the server side, then please let me know. Any help will be appreciated. Thanks.

AndyScherzinger commented 4 years ago

cc @tobiasKaminsky for feedback

@The1ComputerGuy to provide some info/context about this behavior, for uploads the files are actually copy to an internal directory and get deleted after a successful upload.

AlexVerrico commented 4 years ago

Hi @AndyScherzinger Thanks for clarifying that. Perhaps then a feature request would be for the app to follow this workflow: Copy one file -> Upload one file -> Delete temporary file. Instead of what I assume it is doing currently: Copy all files -> Upload all files -> Delete all temporary files. Cheers.

AndyScherzinger commented 4 years ago

@tobiasKaminsky can you on @AlexVerrico's assessment? I guess he is right with how it works today while I haven't had the time to check the code.

tobiasKaminsky commented 4 years ago

Yeah, we have to look into this logic again…

leonhandreke commented 3 years ago

FWIW, this is also happening to me with plenty of free space to copy the files. I'm on LineageOS 17. Please let me know if you need more info.

panomitrius commented 3 years ago

I have a 50gb+ photo library which can't get uploaded because Android nextcloud client wants to copy them somewhere first. I don't get anywhere since I don't have another 50gb space free. Why isn't there an option to just upload, without any copying around on the phone?

peoplenamed commented 2 years ago

Is the copy action needed? This issue is still present.

chromaticsequence commented 2 years ago

So, how much space do I need to upload the files? I can ensure I have enough free disk space but I need to how much I have to free it up.

AlvaroBrey commented 2 years ago

So, how much space do I need to upload the files? I can ensure I have free disk space but I need to how much I have to free up.

Currently, as much space as the files you trying to upload occupy.

@tobiasKaminsky @AndyScherzinger what is the reason behind copying before upload? Perhaps it can be avoided altogether

AndyScherzinger commented 1 year ago

@tobiasKaminsky might remember but I would guess to ensure the files hasn't been touched or is changing while you upload it, since there is no locking of the local file

hakunamatata97k commented 1 year ago

@tobiasKaminsky might remember but I would guess to ensure the files hasn't been touched or is changing while you upload it, since there is no locking of the local file

@AndyScherzinger While this is a valid answer. It doesn't apply on usages where periodic backup is utilized using the app!. Backing up a wapping 210Gb of data from my 250Gb phone on to my server, proves to be an impossible task!. Chunking up would make less sense as well :( Plus assuming I have smaller 60Gb media folders "moving to nextcloud folder" would disrupt the larger file structure! Especially when working with editing videos and images :/ Please provide your take on the subject. :)

flo-kei commented 9 months ago

Is there any plan on improving the current situation? The current implementation is not very usable.

arf20 commented 5 months ago

I second this. The whole point of getting the android app was to backup my photos to my nextcloud instance, it was only when I tried to upload them that I was greeted with this error message. I think this "duplicating everything and uploading the copy" is bad and useless. It requires the uploader to have double the space available of the thing trying to be uploaded. In most cases, pictures. In most cases, pictures take the majority of space in a phone. So this is against the expected use case of the feature. Also useless because in the time nextcloud finishes copying everything, files could have been changed in the process.

Wyzski commented 4 months ago

I am experiencing the same issue described here, any updates or workarounds?

LevAnni777 commented 2 months ago

I can't believe this problem still exists. Why don't just simply upload the file directly to the server instead of copying it to some temporary directory first?

MoritzLange commented 1 week ago

I think a possible workaround, if you want to upload the entire content of one folder (e.g. camera images) to the server, is auto upload. In the app (at least my current Android app) you can go to 'Settings' -> 'Auto upload' and select a folder. Click the ⋮symbol and then 'Configure' to get to a menu where you can specify a remote folder to sync with. In the same menu you can also select whether to upload existing files or only new files.