search

nextcloud / apps

🚚 This is an archive. Let us know if you want to take over maintainership of any of these apps
11 stars 29 forks source link

Update imap.php #33

Closed bjoern86 closed 5 years ago

bjoern86 commented 7 years ago

with this it is possible now to add more than one allowed domain in condig.php:

'user_backends'=>array( array( 'class'=>'OC_User_IMAP', 'arguments'=>array('{mail.server.tld:993/imap/ssl}','domain1.tld, domain2.tld') ) ),

rakshith-ravi commented 5 years ago

@bjoern86 What's the status on this? Can we have this merged into nextcloud?

bjoern86 commented 5 years ago

Status is OK. Yes, can be merged.

violoncelloCH commented 5 years ago

Hi, thank you for your contribution! Since we moved user_external to it's dedicated repository at https://github.com/nextcloud/user_external (I'm one of the new maintainers) could you please reopen your PR there?

Also: Please sign-off on your commits (just add a line like Signed-off-by: Firstname Lastname mail@example.com to every commit). (see https://github.com/nextcloud/server/blob/master/contribute/developer-certificate-of-origin)

jancborchardt commented 5 years ago

@violoncelloCH @bjoern86 @rakshith-ravi is this meanwhile applied at the new repository? :) If not please do, as we want to archive this repository at some point.

violoncelloCH commented 5 years ago

@jancborchardt no this hasn't been applied at the new repo... there is no way to move PRs isn't it? What's the best approach to go for here? However it would probably need some adaptions anyway...

jancborchardt commented 5 years ago

@violoncelloCH since I'm not sure if @bjoern86 wants to pick this up after 2 years, best port it manually to the new repo and credit them in the commit message. :)

(Closing this because yeah, it's not possible to move pull requests.)

violoncelloCH commented 5 years ago

probably, yes... could cherry-pick be a way to keep the original commit?

EDIT: a quick internet search showed me that this is hard to possibly impossible because of the extraction of the user_external subfolder into it's new repo... I guess I'll just do it manually...

violoncelloCH commented 5 years ago

while porting this and thinking it over I don't know if this approach makes sense... especially in combination with (the possibility of) using the domain as a group handle (nextcloud/user_external#65) and making the striping of the domain part optional (nextcloud/user_external#76)... I think a more flexible and at the same time easier to implement approach would be to just configure multiple IMAP backends with the different domains for this use case... this would also allow to set those two preferences per domain...