search

nextcloud / bookmarks

🔖 Bookmark app for Nextcloud
https://apps.nextcloud.com/apps/bookmarks
GNU Affero General Public License v3.0
999 stars 173 forks source link

Bookmark gives error when using the search box #2092

Closed noci2012 closed 9 months ago

noci2012 commented 10 months ago

Describe the bug Notification os error in Bookmarks when doing a search

To Reproduce Steps to reproduce the behavior:

  1. Go to Search box, and type a search string
  2. Click on 'enter'

Expected behavior Not a message about a search failure

Screenshots N/A

Desktop (please complete the following information):

Server (please complete the following information):

Additional context Add any other context about the problem here.

Web server error log

N/A

Nextcloud log (nextcloud/data/nextcloud.log)

Exception: OCP\Search\SearchResultEntry::__construct(): Argument #3 ($subline) must be of type string, null given, 
called in /slowdata/WWW/xxxxxxx/htdocs/apps/bookmarks/lib/Search/Provider.php on line 74 in file
'/slowdata/WWW/xxxxxxxx/htdocs/lib/public/Search/SearchResultEntry.php' line 100

Browser log

N/A
github-actions[bot] commented 10 months ago

Hello :wave:

Thank you for taking the time to open this issue with the bookmarks app. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and have been maintaining this software the last few years. I currently work for Nextcloud but maintain this app in my free time, because it is not an official Nextcloud product. My day job at Nextcloud is pretty awesome but sadly leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself. (Also see our Code of Conduct. Really.)

I look forward to working with you on this issue Cheers :blue_heart:

noci2012 commented 10 months ago

Believe me i tried to fix NC app before (files_opds...) then again got really realy frustrated about the mess that is (hopefully was) the Nextcloud Documentation (API etc.). Examples that could maybe work in NC 10..., i quit that when i discoverd i was starting to reverse engineer NC 20 in my spare time only to discover i could start all over again for NC 21 etc. Even the official documentation could not produce working stuff. The reverse engineering consisted out of examining existing apps ("they worked...") only to find that between 20 ish apps there were 18-ish methods of accessing / configuring NC, and none really fitted the model of the problem i tried to solve.

marcelklehr commented 9 months ago

@noci2012 I feel your pain. Developing code for nextcloud hasn't been easy. I believe we're doing better nowadays, but that still doesn't excuse the sins of the past. Thank you in any case for reporting this bug. :blue_heart: