search

nextcloud / cms_pico

🗃 Integrate Pico CMS and let your users manage their own websites
https://apps.nextcloud.com/apps/cms_pico
GNU Affero General Public License v3.0
137 stars 43 forks source link

Split huge strings into separate strings to make them translatable at Transifex #152

Closed rakekniven closed 3 years ago

rakekniven commented 3 years ago

Reported at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#de_DE/$/308522263?q=issue%3Aopen

The strings are really huge and you cannot handle them without using a third party compare tool.

PhrozenByte commented 3 years ago

Any suggestions?

I'm not even sure whether this particular string is used. It's the app's description in its info.xml (appinfo/info.xml line 9-22). I guess Nextcloud's i18n tools fetch this string to translate the app store description, but I've no idea how to add the translated descriptions to the app store. @nextcloud/appstore any ideas?

More or less the same strings exist in the app's README.md and in the personal settings page. The README.md isn't translated and the string in the personal settings page is already split into smaller strings (templates/settings.personal.php line 42-78). Still no short strings though, but definitely shorter. I'm not sure whether splitting those strings into even more portions will help much. But, as I said, I'm open for suggestions.

rakekniven commented 3 years ago

The app store questions I cannot answer you. Would be a waste of translation power if no one is using the translation.

The smaller portions are already better 👍

Hopefully someone from app store will respond.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two days if no further activity occurs. Thank you for your contributions! :+1:

rakekniven commented 3 years ago

Just adding a comment to prevent the bot closing it. The issue is still there.

My suggestion is to shorten the description.

PhrozenByte commented 3 years ago

The app store description is the primary source for users to learn about Pico CMS for Nextcloud and whether they want to use the app or not. Thus I don't think that shortening it in a way that would make a difference for translators is feasible.

The weird thing is that the devs of Nextcloud's official translation tool (@MorrisJobke @jakobsack) explicitly chose to extract the app's description from info.xml - this is no side effect of a more general implementation, a dev explicitly added code to do this. However, I couldn't find a single app with multilingual descriptions in Nextcloud's app store. So this string appears to be unused. I don't think that this is intentional. We either have

  1. an issue with Nextcloud's official translation tool (@nextcloud/docker) extracting useless strings, or
  2. an issue with Nextcloud's app store (@nextcloud/appstore) not using these strings.

Since Nextcloud's app store doesn't seem to support translated descriptions anyway, I'm totally fine with removing this string. However, I simply don't know how. I don't think that I can even choose to do so. It's something Nextcloud's official translation tool does.

So, I'm sorry, but I unfortunately can't help you. This is something @nextcloud/appstore and/or @nextcloud/docker have to sort out.

rakekniven commented 3 years ago

Hello Daniel,

sorry for the late response. Read your message the first day you wrote it.

You perfectly described the core issue. 👏

Hello @MorrisJobke , do you have any comments on here?

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two days if no further activity occurs. Thank you for your contributions! :+1:

rakekniven commented 3 years ago

@nickvergessen Will app store use translations in the next future?

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two days if no further activity occurs. Thank you for your contributions! :+1:

rakekniven commented 3 years ago

Hello @nextcloud/appstore

please respond someone.

MorrisJobke commented 3 years ago

As of now it's not on the roadmap as we are busy with other stuff. Sorry :/

rakekniven commented 3 years ago

Hello Morris, glad to read some notes from you.

If this is not on the roadmap I am asking "why are the strings from info.xml available at Transifex?".

It is a waste of translation power. Can you disable extracting and adding until it is necessary to translate them?

MorrisJobke commented 3 years ago

If this is not on the roadmap I am asking "why are the strings from info.xml available at Transifex?".

It is a waste of translation power. Can you disable extracting and adding until it is necessary to translate them?

Because they are shown in the app management of the Nextcloud itself. So if the app is downloaded to the Nextcloud server then it shows it in the app management.

PhrozenByte commented 3 years ago

That's weird @MorrisJobke, because my Nextcloud shows English descriptions only (not just for cms_pico, couldn't find a single app with a non-English description in multiple Nextcloud instances, neither enabled nor disabled or uninstalled). Is there some config that needs to be enabled first? Or are they shown somewhere else (not sure about what you mean by "app management")? Or do you mean some non-public overview?

grafik

MorrisJobke commented 3 years ago

That's weird @MorrisJobke, because my Nextcloud shows English descriptions only (not just for cms_pico, couldn't find a single app with a non-English description in multiple Nextcloud instances, neither enabled nor disabled or uninstalled). Is there some config that needs to be enabled first? Or are they shown somewhere else (not sure about what you mean by "app management")? Or do you mean some non-public overview?

Mmmh ... back then we I tested it initially it was working 🙈 ™ Maybe something broke in the meantime, because the text there in the sidebar should™ be translated.

rakekniven commented 3 years ago

I can confirm it is broken in my NC21.

rakekniven commented 3 years ago

Open issue at https://github.com/nextcloud/server/issues/26207

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two days if no further activity occurs. Thank you for your contributions! :+1:

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two days if no further activity occurs. Thank you for your contributions! :+1:

PhrozenByte commented 3 years ago

How do we intend to handle this issue now?

We finally know that the strings exist on purpose and should be translated, even though they aren't used right now (nextcloud/server#26207). Making the description shorter so that it makes a difference for translators isn't feasible in my opinion (see above). As described above, the description is already split into separate strings for in-app usage, however, the app store resp. the app management GUI doesn't support splitting the string into multiple parts right now. I don't think that we (as app developer) can do something about this, right? I'd suggest to close this issue then and rather open a feature request on nextcloud/server to support split app descriptions. Needless to say that I'm very happy to use it then :smiley:

rakekniven commented 3 years ago

@PhrozenByte Agree 💯 % with you.