search

nextcloud / cms_pico

🗃 Integrate Pico CMS and let your users manage their own websites
https://apps.nextcloud.com/apps/cms_pico
GNU Affero General Public License v3.0
137 stars 43 forks source link

False positive: The websites path is stored on a non local storage #161

Closed gpgmailencrypt closed 3 years ago

gpgmailencrypt commented 3 years ago

AFAIK this error message is the result of trying to store on an encrypted storage. On a freshly installed nextcloud 20.0.8 with server-side encryption switched on, but with home storage encryption switched off (see below) I get this error message. I checked it on the server side, files will definitely not be encrypted. Deactivating encryption solves the problem

So it seems to be a false positive.

settings

PhrozenByte commented 3 years ago

This isn't really about whether a particular file is actually encrypted or not, but about how Nextcloud accesses files. As soon as you enable server-side encryption, Nextcloud no longer accesses files directly, but performs instructions on temporary files instead. If you don't encrypt your home storage the temporary file is just a copy of the original file, but it's still not the original file. Pico CMS for Nextcloud (or any other app) won't ever see the original file. We can't do anything about this, it's just how Nextcloud implemented server-side encryption.

gpgmailencrypt commented 3 years ago

Thanks for the info. But nevertheless, theoretically picocms would work correctly under these circumstances. Wouldn't it be a good idea to either reduce the error to a warning or add a "I know what I'm doing"/"Continue on your own risk"-button?

PhrozenByte commented 3 years ago

Pico requires direct file access - which is, as explained above, no longer possible when the admin enables server-side encryption, no matter whether the file is actually encrypted or not.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two days if no further activity occurs. Thank you for your contributions! :+1: