search

nextcloud / event_update_notification

GNU Affero General Public License v3.0
13 stars 3 forks source link

Support ignoring users who unshared from a calendar #100

Closed tcitworld closed 3 months ago

tcitworld commented 5 months ago

https://github.com/nextcloud/server/pull/43117 brings a new share type which needs to be taken into account.

tcitworld commented 5 months ago

What we need is the list of unshares for a calendar, so that we can remove them from the list of users computed from the group shares.

As far as I can see there's no way to get the list of shares including the unshares, so this needs server changes. I would either :

Do you have some input @miaulalala ?

nickvergessen commented 5 months ago

I'll have a look

miaulalala commented 5 months ago

What we need is the list of unshares for a calendar, so that we can remove them from the list of users computed from the group shares.

As far as I can see there's no way to get the list of shares including the unshares, so this needs server changes. I would either :

* `getSharesForId` to have an optional parameter to include unshares

* add a new method to get specifically unshares

Do you have some input @miaulalala ?

I like the unshares method. Optional params are not my fave code construct. OTOH having one query instead of two is a legitimate thought. I leave the implementation details up to you.