nextcloud / forms

📝 Simple form & survey app for Nextcloud
https://apps.nextcloud.com/apps/forms
GNU Affero General Public License v3.0
326 stars 98 forks source link

Submission notification email needs a plural form as multiple users can be present in {user} #2434

Open Mer0me opened 2 days ago

Mer0me commented 2 days ago

Please use the 👍 reaction to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug When multiples users have answered to a form since the last notification email, we receive a mail notification saying "user1 and user2 answered your form". In french translation of this sentence, there is a grammar error. This cannot be fixed in transifex because no plural form is available for this sentence.

To Reproduce Steps to reproduce the behavior:

  1. User1 fills a form
  2. User2 fills the same form
  3. Form owner receives a notification mail with grammar error.

Expected behavior Notification mails should be correct grammatically (in french !).

Screenshots Image "a répondu" should be "ont répondu"

Nextcloud (please complete the following information):

Source ref : https://github.com/nextcloud/forms/blob/f5a51fe8901e7736575aee0cc596587447c5eee5/lib/Activity/Provider.php#L105

cc @rakekniven

rakekniven commented 2 days ago

Plural is needed for german as well.

Chartman123 commented 2 days ago

How about switching this string to passive? 'Your form {formTitle} was answered by {user}'

rakekniven commented 2 days ago

In german it helps as well. Not sure about the languages we support.