nextcloud / health

Nextcloud health app
GNU Affero General Public License v3.0
95 stars 19 forks source link

Wrong version on Nextcloud app store? #174

Closed IndrekHaav closed 10 months ago

IndrekHaav commented 10 months ago

Steps to reproduce

  1. Go to https://apps.nextcloud.com/apps/health#downloads and note the latest version number.
  2. Note the latest version published on Github and listed in the changelog.

Expected behavior

The latest version in the Nextcloud app store should match the latest version on Github and in the changelog.

Actual behavior

The latest version on the Nextcloud app store is 2.1.1, while the latest version on Github and in the changelog is 1.6.3.

Health app version

1.6.2

Additional info

I held off from updating the app, since the jump in version numbers (1.6.2 -> 2.1.1) seemed pretty big, so I came here to check the changelog and noticed the latest version should be 1.6.3 instead. Did the wrong package get pushed to the app store or something?

datenangebot commented 10 months ago

Yes, there is an error happening. Will fix asap.

datenangebot commented 10 months ago

Should be fine now.

IndrekHaav commented 10 months ago

The app store does show version 1.6.3 for NC 28, but still shows version 2.1.1 for several older NC versions. My NC 27 install also still offers version 2.1.1 as an update.

Is this just a caching issue that is expected to resolve itself in due time?

datenangebot commented 10 months ago

@IndrekHaav I am not totally sure where the version 2.1.1. comes from. But all the links point to v1.6.3, that should work. Could you try that?

IndrekHaav commented 10 months ago

I tried updating to 2.1.1, but get this error:

"An error occurred during the request. Unable to proceed. Could not update app."

Nextcloud logs contain the following error:

[no app in context] Error: Exception: App with id health has invalid signature at <<closure>>

0. /var/www/nextcloud/lib/private/Installer.php line 194
   OC\Installer->downloadApp()
1. /var/www/nextcloud/apps/settings/lib/Controller/AppSettingsController.php line 535
   OC\Installer->updateAppstoreApp("*** sensitive parameters replaced ***")
2. /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 230
   OCA\Settings\Controller\AppSettingsController->updateApp("*** sensitive parameters replaced ***")
3. /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 137
   OC\AppFramework\Http\Dispatcher->executeController()
4. /var/www/nextcloud/lib/private/AppFramework/App.php line 183
   OC\AppFramework\Http\Dispatcher->dispatch()
5. /var/www/nextcloud/lib/private/Route/Router.php line 315
   OC\AppFramework\App::main()
6. /var/www/nextcloud/lib/base.php line 1068
   OC\Route\Router->match()
7. /var/www/nextcloud/index.php line 36
   OC::handleRequest()

GET /settings/apps/update/health
from <IP redacted> by indrek at 2023-12-13T12:58:06+00:00

This seems the same error as #172.

Also, even if I were to successfully update to 2.1.1, wouldn't that interfere with updating to future 1.6.x and further versions, since those would semantically be older than 2.1.1?

Edit: a possible fix might be to push an even newer version (like 2.2.0), so it supersedes the problematic 2.1.1 release for all NC versions?

datenangebot commented 10 months ago

This is really strange. I pushed a new version 2.2.2 and the appstore shows this for all supported versions. So I hope this will fix it after the cache gets renewed...

IndrekHaav commented 10 months ago

Looks okay in the app store, but not available on my NC yet:

root@nextcloud:~# occ update:check | grep health
Update for health to version 2.1.1 is available.

I'll keep checking.

louim-lbs commented 10 months ago

Working. Thanks!

IndrekHaav commented 10 months ago

Yep, working here as well, thanks!