nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.
GNU Affero General Public License v3.0
295 stars 258 forks source link

No is_alive init-conaiter on external db #511

Open DrummyFloyd opened 5 months ago

DrummyFloyd commented 5 months ago

Describe your Issue

https://github.com/nextcloud/helm/blob/3b7b2f24ca5c8da56b4ad29b80e66ded4a6da69a/charts/nextcloud/templates/deployment.yaml#L276 https://github.com/nextcloud/helm/blob/3b7b2f24ca5c8da56b4ad29b80e66ded4a6da69a/charts/nextcloud/templates/deployment.yaml#L299

      {{- if or .Values.nextcloud.extraInitContainers .Values.mariadb.enabled .Values.postgresql.enabled .Values.externalDatabase }}
      ....
      {{- if .or Values.mariadb.enabled (eq .Values.externalDatabase.type "mysql")  }}
      ....
      {{- else if or .Values.postgresql.enabled (eq .Values.externalDatabase.type "postgresql") }}

there is such mecanism for db from chart dependencies but none form externalDB would be great to add the condition for the external db

Logs and Errors

none

Describe your Environment



## Additional context, if any
None
jessebot commented 2 months ago

This makes sense. If you'd like, you can submit a PR for this.