[Bug]: In android browser, swiping map from left to right open hamburgar menu, making the UX really bad.

amalgame21 commented 5 months ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] Maps app is up to date. See Maintenance and Release Schedule for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

Every time when swiping the map from left to right, it not only swipe the map from left to right, but also opens the hamburger menu when the finger release from the screen, which is really really disturbing. It happens when opening the shared link of a custom map in android firefox

Steps to reproduce

Share a custom map, and get the shared URL link.
Open the shared custom map link in an android Firefox browser while logout.
Ensure the hamburger menu (showing favorites, tracks, etc) is closed.
Swipe the map from left to right, with the swiping distance long enough (about half of the screen).
While the finger is still touching the screen while swiping to the right, the map also move to the right, which is the desire behavior.
However, when releasing the finger after that swipe, the hamburger menu popup, which is really disturbing.

Expected behavior

Swiping the map do not trigger opening or closing the hamburger menu.

Installation method

Other

Operating system

Other

PHP engine version

PHP 8.1

Web server

Other

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install of the server?

Updated to a major version (ex. 22.2.3 to 23.0.1)

Is this bug present after an update or on a fresh install of the app?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

[X] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

No response

List of activated Apps

Enabled:
  - activity: 2.21.1
  - calendar: 4.7.6
  - circles: 29.0.0-dev
  - cloud_federation_api: 1.12.0
  - comments: 1.19.0
  - contacts: 6.0.0
  - contactsinteraction: 1.10.0
  - dashboard: 7.9.0
  - dav: 1.30.1
  - end_to_end_encryption: 1.15.2
  - federatedfilesharing: 1.19.0
  - federation: 1.19.0
  - files: 2.1.0
  - files_downloadlimit: 2.0.0
  - files_pdfviewer: 2.10.0
  - files_reminders: 1.2.0
  - files_sharing: 1.21.0
  - files_trashbin: 1.19.0
  - files_versions: 1.22.0
  - firstrunwizard: 2.18.0
  - groupfolders: 17.0.0
  - logreader: 2.14.0
  - lookup_server_connector: 1.17.0
  - maps: 1.4.0
  - memories: 7.3.1
  - nextcloud_announcements: 1.18.0
  - notifications: 2.17.0
  - oauth2: 1.17.0
  - onlyoffice: 9.2.2
  - password_policy: 1.19.0
  - photos: 2.5.0
  - previewgenerator: 5.5.0
  - privacy: 1.13.0
  - provisioning_api: 1.19.0
  - recommendations: 2.1.0
  - related_resources: 1.4.0
  - serverinfo: 1.19.0
  - settings: 1.12.0
  - sharebymail: 1.19.0
  - support: 1.12.0
  - survey_client: 1.17.0
  - systemtags: 1.19.0
  - tasks: 0.16.0
  - text: 3.10.0
  - theming: 2.4.0
  - twofactor_backupcodes: 1.18.0
  - twofactor_webauthn: 1.4.0
  - updatenotification: 1.19.1
  - user_status: 1.9.0
  - viewer: 2.3.0
  - weather_status: 1.9.0
  - workflowengine: 2.11.0

Nextcloud Signing status

No response

Nextcloud Logs

No response

Browser Console

No response

Additional info

No response

amalgame21 commented 5 months ago

Sorry I don't understand javascript but I found something seems related.

I found one mentioned OC.disallowNavigationBarSlideGesture() here: https://github.com/nextcloud/maps/issues/56#issuecomment-526023126

For this I think we have to disable the swipe-open functionality of snap.js (which handles the sidebar open). Do you know how to do this @skjnldsv @juliushaertl? Also this might be something for core, as it leads to issues not only here …

I think you can use OC.disallowNavigationBarSlideGesture()

And I found this related commit containing the code: https://github.com/nextcloud/maps/commit/b0a96c6d3fa76ffb7a0adb62a8251ee07e8fccac

However those code and even the file is gone now, maybe the app is rewritten? Is it the reason why swiping the map open the sidebar or hamburger menu?

ant0nwax commented 1 month ago

+1, sometimes happens, i came to the point when i swipe from left to right only starting carefully in the middle and going to the right

nextcloud / maps