search

nextcloud / news-android

📱🗞️ Android client for the Nextcloud news/feed reader app
https://play.google.com/store/apps/details?id=de.luhmer.owncloudnewsreader
GNU Affero General Public License v3.0
699 stars 257 forks source link

Starred items are not synced correctly #344

Closed godfuture closed 4 years ago

godfuture commented 9 years ago

Hello together, my server shows 172 starred items, my client only 9. Seems that these items are not synced to client, not even with initial sync. I have tested adding a new starred item at server which was synced to client. But deleting it at server, does not remove it at client after sync. So I guess the starred item sync has its issues.

I could not find a pattern to identify/describe the missing starred items at client.

Edit: It seems that I cannot even unstar certain (old?) items on server. Is there any difference of starred items over serval version of OC news and android app? How could I identify such version issues for both sides?

mjohenneken commented 9 years ago

I ran into the same issue after updating to Owncloud 8. I added a Connection to the new Server and none of the previous starred feeds were downloaded. My News App in the Owncloud webinterface shows 176 starred items.

David-Development commented 9 years ago

If you have more than 2000 (I don't know exactly) unread items no starred items will be downloaded. This is because I want the app to be fast and responsible. Currently I've 13000 unread items and this makes the app really slow. So the app will only store starred items up to 2000 total (unread and starred items). Small example: E.g. you have 500 unread items the app will download 1500 starred items. If you have 2500 unread items the app won't download starred items.

mjohenneken commented 9 years ago

Okay that is reasonable, but I think the more intuitive way would be, to prefer starred items in a sync process, The user is more intrested in his starred items as in unread items. Also if the user wants to have his starred items he has to remove all unread items, which is no option in my case. If there are new items on the server which won't be loaded, it wouldn't be so problematic, because i have still unread items on my device.

David-Development commented 9 years ago

Okay but the user might have also a few thousand starred items and we can't sync them all to the device (for performance reasons). Probably we can say that at least ~200 starred items are synced anyway. Would that be okay for you?

godfuture commented 9 years ago

Thanks for reporting on my request.

From performance point of view...is syncing one starred item the same "effort" as syncing one unread? I guess introducing a minimal number of starred items will solve my issue now, but might not in future. And I guess that this solution may be a compromise, but not a real solution. As the user might decide on his own if he accepts the app responsive or less responsive, would it be possible to warn the user about probable slow sync, if the total unread count exceeds a certain amount with the possibility to disable further warnings?

godfuture commented 9 years ago

any news?

UnnamedHero commented 8 years ago

I'm suffering from the same issue. Using OC 9.0.2. OC app 8.8.0, app 0.9.8.7

I have 300+ starred items, and only 12-15 are synced to android app.

And the api request curl -u USER "OC_URL/index.php/apps/news/api/v1-2/items?type=2&getRead=true&batchSize=-1" returns 700Kb json

ghtux commented 6 years ago

Same Problem here. Lineage android 7. It doesn't fetch favorites even after clearing cache

CombeeMike commented 6 years ago

I'm experiencing the same issue. I've installed the news app on a new BQ phone with (almost) stock Android 8.1.0.

I have 0 unread items & 21 starred ones in the web client but only 5 of them are shown in the Android app. The app crashes when clicking on the Download more items menu item with the Starred items category open...

Pressing the Clear cache button in the settings shows me a the following warning, but doesn't download more items:

There are unsynchronized changes. Would you like to reset the cache anyway?

Further info:

David-Development commented 6 years ago

@CombeeMike Thanks for the feedback. You said

The app crashes when clicking on the Download more items menu item with the Starred items category open

could you provide a stack trace? There might be some feeds that contain some unexpected formatting..

CombeeMike commented 6 years ago

Hi @David-Development,

after switching phones again & reinstalling the app, I now see all starred items in the app, so the reported issue itself seems "solved" for me.

Nonetheless, when clicking on the Download more items button, the app still crashes. I'm happy to provide you the stack trace but don't know, how to do that. Could you give me some instructions or a link?

I guess clicking on Androids built in Send feedback is not helping you here...

sotpapathe commented 4 years ago

Still having this issue on version 0.9.9.32. With 1 unread article and 83 starred on the web, only the unread article and the 2 that I starred since I installed the app are visible in the app. I cleared the cache as suggested in issue #403 and only the unread article was synced in this case. Selecting Download more items crashes the app.

Tha-Fox commented 4 years ago

I have this situation with version 0.9.9.36. I have 0 unread "normal" news and 75 favorites. My mobile shows 8 favorites. If I click "download more items", the application crashes.

Djyp commented 4 years ago

I'm running 0.9.9.36 from F-Droid.

There has been a development.

This morning the sync didn't sync the 100 starred items, but it correctly synced the new items, as usual. I sorted starred items a few hours earlier today, dropped from a 100 items to 49. I just resynced the app and I have the 49 items on my phone now!

getwet commented 4 years ago

I've got the same problem. I had to new install my android app and can't see any starred news. On my server I see 40 starred news. App version is 0.9.9.36. No problem with OCRreader. But I like the news app much more. :-) Download more crashed the app.

David-Development commented 4 years ago

Sorry for the delay on this. It appears that there are still some issues here.. I will have another look into it. I think this has something to do with the number of unread items on the server.

For anyone that couldn't see any starred items in the app, can you please run the following command (@getwet) and tell me what number you see in the end?:

curl -s -u <your_username> https://nextcloud.<yourdomain>.com/index.php/apps/news/api/v1-2/items\?batchSize=-1\&offset=0\&type=3\&getRead=false |grep -o "starred\":true" |wc -l

What number do you see in the webinterface of the news app? Does it match the number of starred articles? And what number do you see in the android news app?

David-Development commented 4 years ago

After looking into it I found some issues with the sync of the starred articles. I'll try to get the fix out soon however google has been rejected my past couple releases so fingers crossed that it'll go trough!

getwet commented 4 years ago

Sorry for the delay on this. It appears that there are still some issues here.. I will have another look into it. I think this has something to do with the number of unread items on the server.

For anyone that couldn't see any starred items in the app, can you please run the following command (@getwet) and tell me what number you see in the end?:

curl -s -u <your_username> https://nextcloud.<yourdomain>.com/index.php/apps/news/api/v1-2/items\?batchSize=-1\&offset=0\&type=3\&getRead=false |grep -o "starred\":true" |wc -l

What number do you see in the webinterface of the news app? Does it match the number of starred articles? And what number do you see in the android news app?

With your command I see 0. At nextcloud/news I see 64.

David-Development commented 4 years ago

@getwet Please test the latest beta release on the play store (you can also get the apk here). You probably need to clear the cache. Open the app, go to the settings, click on "Clear cache".

getwet commented 4 years ago

I installed the app on my testphone and it looks good. After a new login I see 64 starred news! Great work. TOP!

getwet commented 4 years ago

Do you have Paypal?

David-Development commented 4 years ago

@getwet I do have paypal (paypal.me/davidluhmer). Thank you 🙇

getwet commented 4 years ago

Check your account ;-)

getwet commented 4 years ago

FYI: Your version 0.9.9.40 is now on fdroid. Clear the cache data was not anough to get it fixed. I had to clear all data to see all starred items. And it's still crashing when load further articles.

David-Development commented 4 years ago

Check your account ;-)

Thank you for the generous donation! :)

Clear the cache data was not enough to get it fixed.

Ugh.. my bad, I think logging in again should also do the trick (since a fresh sync will be triggered)

And it's still crashing when load further articles.

Yes, the fix wasn't included in the 0.9.9.40 release. It will be included once I merge the following PR (https://github.com/nextcloud/news-android/pull/884)

Tha-Fox commented 4 years ago

I can also confirm that 0.9.9.40 fixes the issue. In the previous version it downloaded only the starred items that were added after the initial sync. Great work, thank you!

LeoSum8 commented 3 years ago

I am having problems with syncing my favourites/starred items in the latest version (0.9.9.60) from F-Droid.

In the webapp I have 184 starred items, all of them read. The android-app only retrieves 7 random starred items though.

the output of curl -s -u <your_username> https://nextcloud.<yourdomain>.com/index.php/apps/news/api/v1-2/items\?batchSize=-1\&offset=0\&type=3\&getRead=false |grep -o "starred\":true" |wc -l is 0, if I use getRead=true the output is 184.

I also tried clearing cache, data, uninstalling/reinstalling. It only fetches the 7 same starred items.