l10n: Add singular and plural

nextcloud / ocsms

📱 Nextcloud/ownCloud PhoneSync server application

https://play.google.com/store/apps/details?id=fr.unix_experience.owncloud_sms

GNU Affero General Public License v3.0

189 stars 52 forks source link

l10n: Add singular and plural #324

Open Valdnet opened 4 years ago

Valdnet commented 4 years ago

I propose to add singular and plural variation for a text string:

%s messages shown of %s messages stored in database.

https://github.com/nextcloud/ocsms/blob/5391cd9c3f67ca6da517f8dc885b53171a657832/templates/main.php#L121

May be helpful: https://github.com/nextcloud/server/blob/a2a3b87c19662f06cfb804b9fead7e939b1c3e6c/core/src/globals.js#L139-L148

e-alfred commented 3 years ago

Could you provide a PR for this change?

Valdnet commented 3 years ago

@e-alfred I think this should be done by someone who knows more about PHP programming 😉.

e-alfred commented 3 years ago

Is this the only occurrence? Did you find more instances that should be changed? I changed this particular one last time at the request of @rakekniven.

Valdnet commented 3 years ago

Is this the only occurrence? Did you find more instances that should be changed?

So far, only this string text has noticed.

rakekniven commented 3 years ago

Just did a blame and remember now :-) My thoughts have been that you will not have only one message in your database and instead of overworking the code I just made a tiny suggestion to only use plural form.

Valdnet commented 3 years ago

My thoughts have been that you will not have only one message in your database

@rakekniven But you also have to take into account the number of messages to be displayed :wink:.