nextcloud / passman-webextension

Webextension for the Passman Nextcloud app. Also offers browser extension & Android app.
https://passman.cc
GNU Affero General Public License v3.0
114 stars 43 forks source link

Saving passwords manually are not saved in nextcloud #221

Open ghost opened 6 years ago

ghost commented 6 years ago
### Steps to reproduce 1. Call up website with saved password by FF 57 Password Manager 2. Click next to password field on blue icon to save credentials manually 3. Extensions says password saved but it's not. Upon clicking the refresh icon it resets it's password count to zero - nothing shows up in my nextcloud 12 installation. 4. However, when I call up the website and just click login using the saved credentials in firefox, the webextension says "passwords detected, save them?". When clicking yes here, they're saved. So I guess the manual "add" Dialog before clicking the login button is broken. 5. Saved URL after logging in (in case of Github for testing this extension) is the 2factor Code URL, not the one it was when the credentials where needed (github.com/login instead of https://github.com/sessions/two-factor). ### Expected behaviour Saving credentials before loggin in when firefox has filled out the username and password fields already should work the same like when the extension detects a successfull login. ### Actual behaviour See reproduced steps ### Configuration **Operating system**: Max OS 10.10.5 **Browser**: Latest Firefox Quantom stable release **Extensions that might cause interference**: If I'd know ... **Passman version**: 2.1.4 **Extension version**: 2.0.4 **Nextcloud version**: 12.0.4 #### Browser log Nothing I could log --- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/52515318-saving-passwords-manually-are-not-saved-in-nextcloud?utm_campaign=plugin&utm_content=tracker%2F52236699&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F52236699&utm_medium=issues&utm_source=github).
gnouts commented 6 years ago

I can confirm this behavior on Linux (kernel 4.9.77) with Firefox 57 and Chromium 63 (Same version for passman and nextcloud) Is this related to https://github.com/nextcloud/passman-webextension/issues/222 ?

brantje commented 6 years ago

@ghost / @gnouts can one of you make a little gif that demonstrates it? As far i understand this issue, i need to

Correct?