nextcloud / recognize

šŸ‘ šŸ‘‚ Smart media tagging for Nextcloud: recognizes faces, objects, landscapes, music genres
https://apps.nextcloud.com/apps/recognize
GNU Affero General Public License v3.0
539 stars 45 forks source link

Clicking on recognized image does not thow full size image #1099

Closed tjakober closed 4 months ago

tjakober commented 7 months ago

Which version of recognize are you using?

6.0.1

Enabled Modes

Object recognition, Face recognition

TensorFlow mode

WASM mode

Downstream App

Photos App

Which Nextcloud version do you have installed?

28.0.2

Which Operating system do you have installed?

Docker instance

Which database are you running Nextcloud on?

Mariadb 10.11.6

Which Docker container are you using to run Nextcloud? (if applicable)

linuxserver/nextcloud

How much RAM does your server have?

8GiB

What processor Architecture does your CPU have?

Intel Atom C2538

Describe the Bug

In Fotos App under People clicking on a recognized face. Then clicking on the thumbnail of one of the associated fotos, it only shows a turning circle forever

Expected Behavior

showing the full size image of the thumbnail.

To Reproduce

  1. Go to Photos App
  2. Click on People
  3. Click on one of the thumbnails which are displayed

Debug log

TypeError
OCA\Recognize\Dav\Faces\UnassignedFacePhoto::__construct(): Argument #5 ($preview) must be of type OCP\IPreview, null given, called in /config/www/nextcloud/apps/recognize/lib/Dav/Faces/UnassignedFacesHome.php on line 108
/config/www/nextcloud/apps/recognize/lib/Dav/Faces/UnassignedFacesHome.php
Zeile 108
OCA\Recognize\Dav\Faces\UnassignedFacePhoto->__construct()
OCA\Recognize\Dav\Faces\UnassignedFacesHome->OCA\Recognize\Dav\Faces\{closure}(
  "*** sensitive parameters replaced ***"
)
/config/www/nextcloud/apps/recognize/lib/Dav/Faces/UnassignedFacesHome.php
Zeile 107
undefinedundefinedarray_map()
/config/www/nextcloud/apps/recognize/lib/Dav/Faces/PropFindPlugin.php
Zeile 71
OCA\Recognize\Dav\Faces\UnassignedFacesHome->getChildren()
/app/www/public/3rdparty/sabre/dav/lib/DAV/PropFind.php
Zeile 95
OCA\Recognize\Dav\Faces\PropFindPlugin->OCA\Recognize\Dav\Faces\{closure}(
  "*** sensitive parameters replaced ***"
)
/config/www/nextcloud/apps/recognize/lib/Dav/Faces/PropFindPlugin.php
Zeile 71
Sabre\DAV\PropFind->handle()
/app/www/public/3rdparty/sabre/event/lib/WildcardEmitterTrait.php
Zeile 89
OCA\Recognize\Dav\Faces\PropFindPlugin->propFind()
/app/www/public/3rdparty/sabre/dav/lib/DAV/Server.php
Zeile 1052
Sabre\DAV\Server->emit()
/app/www/public/3rdparty/sabre/dav/lib/DAV/Server.php
Zeile 984
Sabre\DAV\Server->getPropertiesByNode()
/app/www/public/3rdparty/sabre/dav/lib/DAV/Server.php
Zeile 1662
Sabre\DAV\Server->getPropertiesIteratorForPath()
/app/www/public/3rdparty/sabre/dav/lib/DAV/Server.php
Zeile 1647
Sabre\DAV\Server->writeMultiStatus()
/app/www/public/3rdparty/sabre/dav/lib/DAV/CorePlugin.php
Zeile 346
Sabre\DAV\Server->generateMultiStatus()
/app/www/public/3rdparty/sabre/event/lib/WildcardEmitterTrait.php
Zeile 89
Sabre\DAV\CorePlugin->httpPropFind()
/app/www/public/3rdparty/sabre/dav/lib/DAV/Server.php
Zeile 472
Sabre\DAV\Server->emit()
/app/www/public/3rdparty/sabre/dav/lib/DAV/Server.php
Zeile 253
Sabre\DAV\Server->invokeMethod()
/app/www/public/3rdparty/sabre/dav/lib/DAV/Server.php
Zeile 321
Sabre\DAV\Server->start()
/config/www/nextcloud/apps/dav/lib/Server.php
Zeile 370
Sabre\DAV\Server->exec()
/config/www/nextcloud/apps/dav/appinfo/v2/remote.php
Zeile 35
OCA\DAV\Server->exec()
/app/www/public/remote.php
Zeile 172
undefinedundefinedrequire_once(
  "/config/www/nextcloud/apps/dav/appinfo/v2/remote.php"
)
github-actions[bot] commented 7 months ago

Hello :wave:

Thank you for taking the time to open this issue with recognize. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself. (Also see our Code of Conduct. Really.)

I look forward to working with you on this issue Cheers :blue_heart:

nordscan commented 7 months ago

the same

image

marcelklehr commented 4 months ago

This will be fixed in the next photos app release.