Talk meetings on shared nc office files with guest cannot be performed

stoneubi commented 3 weeks ago

Hi there,

my actual versions are:

NC 29.0.7
Talk 19.0.9
NC Office 8.4.6
Share settings: allow

grafik

Description / steps to reproduce:

create a new e.g. presentation
press the share button directly at the presentation creation / modify screen and select Chat
as described you have to share the presentation before you can discuss it -> share the presentation to a guest per email invitation
allow the guest to edit the presentation
click on the link at the invitation email
the browser opens, for a second you can see the regular view same as if you share files and on the right side there would be the chat part but the browser changes to the next screen where the presentation opens in nextcloud office
at this stage you cannot chat with anyone other -> there is no chat part and you cannot open talk or chat

The thing is that you want to discuss a presentation with a guest, you share the presentation but then you cannot use talk.

If you close the presentation, the chat view will be visible: grafik

and you can open the chat part -> you have to enter a name. Now you are in the chat part but cannot modify the presentation together with someone else.

How can the system be configured to allow talk meetings during a collaborate file creation / modification with guests = no nextcloud user.

Thank you, Stoneubi

Antreesy commented 3 weeks ago

Sidebar availability is fixed in nextcloud/spreed#13308
[x] Solution should be backported to stable28/29 / if nextcloud/vue version is 8.13.0 or higher

nickvergessen commented 2 weeks ago

should be backported to stable28/29 / if nextcloud/vue version is 8.13.0 or higher

Can you check and confirm?

Antreesy commented 4 days ago

Fix is in there and restores access to chat sidebar from public link. But Office integration doesn't show a toggle for guests, it seems. so I'd check with Office team, if they can provide it

Guest	User

juliushaertl commented 3 days ago

Two questions:

How can we check from the richdocuments app if the sidebra should be shown (assuming there is a setting for it from the above screenshots)
How can we trigger/toggle the sidebar in the frontend? Maybe you have any code pointers there?

Antreesy commented 3 days ago

How can we check from the richdocuments app

This returns a conversation token for public share: https://github.com/nextcloud/spreed/blob/1ccbf67da231c37801c1406b10000144125aec35/src/services/filesIntegrationServices.js#L28-L31

If response is successfull = Talk is available, and conversation can be joined

How can we trigger/toggle the sidebar in the frontend?

We already have a trigger mounted in DOM - in NC header (but it's behind the Office integration): https://github.com/nextcloud/spreed/blob/976f67921c09848e0780cd8c1b70b663cf587c50/src/mainPublicShareSidebar.js#L74

Maybe just shrinking of Office integration would be enough (similar to how it's done for Files app?)

juliushaertl commented 3 days ago

This returns a conversation token for public share: https://github.com/nextcloud/spreed/blob/1ccbf67da231c37801c1406b10000144125aec35/src/services/filesIntegrationServices.js#L28-L31

If response is successfull = Talk is available, and conversation can be joined

We'd need a backend way but guess we can dig this up from the route then.

Thanks for the pointers

nextcloud / richdocuments

Talk meetings on shared nc office files with guest cannot be performed #4105