Open tobiasKaminsky opened 5 years ago
- once a notification is dismissed this should be sent as "deleted" event with id to all devices so they can remove the pending push notification
@nickvergessen can I send custom push notifications to me, so that I can test this?
This works really nice:
@nickvergessen this is of course only a test and should then be done in a safer way, maybe we can use "app" for this? "delete_notification" as app. Also this notification then should not be shown/stored at all on server.
(https://github.com/nextcloud/notifications/blob/master/docs/push-v2.md)
* on receiving a push notification, I first check for delete subject, if not regular notification is shown else I delete the shown notification (if available)
Only delete it if the id matches of course ;)
Hi, next week I will implement this ... now I am too busy for remake of tab "Media" ...
For receiving "hidden" push messages to delete the notifications on screen, we would need implementation by @nickvergessen.
First marino needs to move iOS to PushKit, otherwise he can not hide/delete notifications, which would mean the delete notifications would also show up
Ah, ok did not know about iOS internals, but on Android we receive a push and then can decide if we want to show a notification.
But then this is step 2 :-)
Soon !! (next week) @Ivansss ;)
ping @rullzer to have a look into push server side
Why?
@nickvergessen cause you are busy in talk and we wanted to keep work off you.
First marino needs to move iOS to PushKit, otherwise he can not hide/delete notifications, which would mean the delete notifications would also show up
@marinofaggiana have you already switched to PushKit?
Yes, it was done yesterday+today.
However beta2 just went out, i guess we have to wait one more release?
Great to hear :-) Then we can start implementing it. I guess, @nickvergessen the server/app has to start, or? :tada:
Re-opening as this is missing on desktop (sync without push) and iOS.
Re-opening as this is missing on desktop (sync without push) and iOS.
cc @camilasan @marinofaggiana
Is this still not yet implemented on Desktop and iOS? If it is, please close this issue. Thanks!
iOS is done.
cc @nextcloud/desktop
Done
When receiving a notification:
On Android/iOS:
On Desktop:
Missing: iOS @nextcloud/ios:
Android @nextcloud/android:
On server @nickvergessen:
Desktop @nextcloud/desktop: