[Bug]: (CalDAV) Calendar event cancellation iMip messages are sent twice, on delete and on trash empty

SebastianKrupinski commented 1 month ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

Calendar iMip messages are sent twice, once when the event is deleted and once when the trash is emptied

Steps to reproduce

Create Event (In the future) with attendee (has email address)
Delete Event with attendee
Empty trash bin

Expected behavior

Calendar iMip message should only be sent once on delete

Installation method

None

Nextcloud Server version

master

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Nginx

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

[ ] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

N/A

List of activated Apps

N/A

Nextcloud Signing status

N/A

Nextcloud Logs

N/A

Additional info

No response

SebastianKrupinski commented 1 month ago

Tested with single and multiple attendees and external email client

Created Event Message Created

Deleted Event Message Deleted

Trash Empty Message Trash Emptied

SebastianKrupinski commented 1 month ago

Possible solution.

Add check to determine if message was deleted or trash was emptied in iMipPlugin Schedule function.

https://github.com/nextcloud/server/blob/94bc020d073011eec8e1f084e9521356574e42f7/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php#L106

nextcloud / server