nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.54k stars 4.08k forks source link

fix: invalid usage of IQueryBuilder::createNamedParameter() #49454

Closed st3iny closed 3 days ago

st3iny commented 5 days ago

Summary

I'm sorry, I missed some issues during my code review.

  1. Creating a parameter without a value is done via IQueryBuilder::createParameter().
  2. Fixed a small typo.
  3. Fixed inconsistent and missing types for parameters to improve compatibility with oci.

See also https://github.com/nextcloud/server/pull/49428#discussion_r1853896702

Checklist

st3iny commented 5 days ago

/backport to stable30

st3iny commented 5 days ago

/backport to stable29

st3iny commented 5 days ago

/backport to stable28

SebastianKrupinski commented 5 days ago

He, can we cancel the back ports of this? I was just going to adjust the original backports.

st3iny commented 5 days ago

He, can we cancel the back ports of this? I was just going to adjust the original backports.

I'd say no. For consistency it is better to merge the other backports and then backport this PR.