search

nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.54k stars 4.08k forks source link

Link to a specific task brings to task list rather than to the particular task #49473

Open hbarel opened 4 days ago

hbarel commented 4 days ago

Steps to reproduce

  1. Click on a task link anywhere in Nextcloud, e.g., in search results.
  2. The Tasks application will be invoked, but the clicked task will not be selected nor displayed.

Expected behavior

One would expect that the task of the link will be displayed, or at least selected, as happens with clicked events.

Actual behaviour

The list of tasks appears, as it does when opening the Tasks application, without any reference to the task of the clicked link.

Tasks app version

0.16.1

CalDAV-clients used

No response

Browser

Chrome

Client operating system

Debian

Server operating system

Debian

Web server

Apache

Database engine version

MariaDB

PHP engine version

PHP 8.2

Nextcloud version

30.0.2

Updated from an older installed version or fresh install

Updated from an older version

List of activated apps

Nextcloud configuration

Web server error log

Log file

Browser log

Additional info

No response

raimund-schluessler commented 3 days ago

Thanks for the report. This is a problem in server, as the route to the task is created wrongly. The underlying reason is, that the routes to lists and tasks changed with 0.16.0, see https://github.com/nextcloud/tasks/pull/2480 and this was not adjusted in server yet.

The link from server currently reads e.g. <nextcloud-url>/apps/tasks/#/calendars/list1/tasks/task-id.ics where it should be <nextcloud-url>/apps/tasks/calendars/list1/tasks/task-id.ics (notice the additional /# in the wrong link).

raimund-schluessler commented 3 days ago

This needs to be adjusted here

https://github.com/nextcloud/server/blob/235b7d7c26930367533f2e845bb2180ba9151608/apps/dav/lib/Search/TasksSearchProvider.php#L124

@ChristophWurst Tasks 0.16.0 is available from NC28 onwards. Should we adjust this from there? The proper solution would have been to release Tasks 0.16.0 only for newer server versions, but I didn't notice that this will break when I released 0.16.0. So we might have to go with a fix that will break the behaviour for servers running Tasks older than 0.16.0.

ChristophWurst commented 3 days ago

I'm fine with backporting a fix to stable28 assuming that someone updating to the latest server 28 will also run the latest Task app for that release