Open nickvergessen opened 7 years ago
This would allow the files_texteditor to register for text files, while richdocuments can also, so in case files_texteditor is not there, you can still edit them.
I like that approach more. The cleaner hack. But still feels like a hack.
I'd rather prefer a "Open with" dialogue but yay, JavaScript 😉
I suppose this issue is still valid? If not, please close this issue!
There are priorities for file actions now, but we still have two problems:
1 is a server issue (this on) and 2 is a viewer issue and handled here: https://github.com/nextcloud/viewer/issues/2393
Steps to reproduce
I think it would be nice to have something like a priority of the actions. Currently the last one wins, and since richdocuments is after files_texteditor in the alphabet, files_texteditor has no way to ever win this.
Proposal is to add something like priority to: https://github.com/nextcloud/server/blob/2b794902014264a3793daf42a2ecfa95a1a07342/apps/files/js/fileactions.js#L144-L144
and then:
This would allow the files_texteditor to register for text files, while richdocuments can also, so in case files_texteditor is not there, you can still edit them.
Alternate approach would be hacking into richdocuments to only register, when files_texteditor is not there.
cc @MorrisJobke @LukasReschke
cc @RealKelsar for reporting it in IRC