Versioning: show restore in activity stream

nextcloud / server

☁️ Nextcloud server, a safe home for all your data

https://nextcloud.com

GNU Affero General Public License v3.0

27.5k stars 4.08k forks source link

Versioning: show restore in activity stream #9733

Open tobiasKaminsky opened 6 years ago

tobiasKaminsky commented 6 years ago

open up a file in detail view
restore it to any previous version
expect: see something in activity stream, e.g. "Restored to version from 01.05.18".

Currently the only changing part is the available versions. As I am also developing this on android, I think some kind of feedback would be nice, to track the changes of a file.

MorrisJobke commented 6 years ago

cc @nickvergessen @rullzer

nickvergessen commented 6 years ago

https://github.com/nextcloud/server/blob/0b883ab9d940650582e8ee02ada5bf13c2be7915/apps/files/lib/Activity/Provider.php#L215-L218

We have restore already, only the timestamp information is missing. But sounds like a good addition.

tobiasKaminsky commented 6 years ago

@nickvergessen this is somehow strange, as it is in not shown on my master server, neither in file detail stream or activities stream.

Can I debug this? Is this working for you?

nickvergessen commented 6 years ago

Ah, sorry this is for restore from trashbin.

Restoring a version is missing, yes.

tobiasKaminsky commented 6 years ago

If we even get confused by this, then we should maybe change the text a bit: 'You restored {file}' -> 'You restored {file} from deleted files.' and 'You restored version at $date from {file}.'

szaimen commented 3 years ago

I'm closing this issue due to inactivity. Please reopen if you still want to implement this.

tobiasKaminsky commented 3 years ago

This is still a valid enhancement idea. I do understand to close bugs, which might be outdated…