search

nextcloud / terms_of_service

📜 Requires users to accept the terms of service before accessing data.
https://apps.nextcloud.com/apps/terms_of_service
GNU Affero General Public License v3.0
29 stars 19 forks source link

TOS breaks PicoCMS #274

Open codejp3 opened 4 years ago

codejp3 commented 4 years ago

"Call to undefined method ParsedownExtra::textElements()" in PicoCMS with TOS enabled.

Please reference the thread on PicoCMS about this issue.

https://github.com/nextcloud/cms_pico/issues/97

rollanders commented 4 years ago

@nickvergessen @PhrozenByte I will lift this issue as important to solve. I want both social login and PicoCMS Is Parsedown necessary for TOS?

nickvergessen commented 4 years ago

Is Parsedown necessary for TOS?

We use it to be able to use markdown in your terms of service, so yes kind of.

ChristophWurst commented 4 years ago

Ref https://github.com/ChristophWurst/nextcloud_sentry/pull/172

PhrozenByte commented 4 years ago

@ChristophWurst Subscribed to your issue for updates. Since it's an ecosystem issue, are we going to see this being officially supported by Nextcloud? IMO it would be a good thing to give @coenjacobs some support (and some visibility) by Nextcloud, as it looks like he's doing this on his own... It's neither just Guzzle nor Parsedown, it's kind of a miracle that these kind of conflicts don't happen more often...

nickvergessen commented 4 years ago

Well every app can/should do this when it has such problems. It's nothing Nextcloud can fix for all app maintainers

PhrozenByte commented 4 years ago

@nickvergessen It's all about recommendations and documentation :wink:

ChristophWurst commented 4 years ago

I want to explore these tools a bit more. If they can be used reliably, we can add them to our docs.

While it currently doesn't help with Guzzle conflicts, it could work with parsedown. You may look at my PR and just try to apply it here. Then check if the app still works :)