nextgis / quickmapservices

QGIS plugin to find and add map services to a project in one click
http://plugins.qgis.org/plugins/quick_map_services/
GNU General Public License v2.0
170 stars 49 forks source link

QGIS 3.0.1 - Invalid WMS Layer causes crash #160

Closed ingalls closed 6 years ago

ingalls commented 6 years ago

QuickMapServices Plugin crashed when attempting to add a new custom WMS layer.

Steps Taken Before Crash:

Property Value
ID MapboxStreets
Alias Mapbox Streets
Icon Didn't change
Group OSM
Type WMS

Operating System: Ubuntu 17.04 Python Version: 3.6.3 (default, Oct 3 2017, 21:45:48) [GCC 7.2.0] QGIS Version: 3.0.1-Girona Girona, a86bec2

Error Thrown:

TypeError: expected str, bytes or os.PathLike object, not tuple 
Traceback (most recent call last):
  File "/home/null/.local/share/QGIS/QGIS3/profiles/default/python/plugins/quick_map_services/ds_edit_dialog.py", line 163, in accept
    self.feel_ds_info(new_ds_info)
  File "/home/null/.local/share/QGIS/QGIS3/profiles/default/python/plugins/quick_map_services/ds_edit_dialog.py", line 262, in feel_ds_info
    ds_info.icon = os.path.basename(self.__ds_icon)
  File "/usr/lib/python3.6/posixpath.py", line 144, in basename
    p = os.fspath(p)
TypeError: expected str, bytes or os.PathLike object, not tuple
alisovenko commented 6 years ago

Please try version 0.19.7

ingalls commented 6 years ago

Thanks for the prompt fix @alisovenko, really appreciate it!

screenshot from 2018-03-29 13-22-54