search

nextgis / quickmapservices

QGIS plugin to find and add map services to a project in one click
http://plugins.qgis.org/plugins/quick_map_services/
GNU General Public License v2.0
170 stars 49 forks source link

Clarify 3857 as EPSG code to avoid deprecation. #215

Closed drf5n closed 3 years ago

drf5n commented 4 years ago

Avoid deprecation warning from https://qgis.org/pyqgis/master/core/QgsCoordinateReferenceSystem.html

agiudiceandrea commented 3 years ago

@drf5n please see my previously submitted PR https://github.com/nextgis/quickmapservices/pull/204 Anyway it seems there is no willingness to update the plugin by the plugin devs.

simgislab commented 3 years ago

so

QgsCoordinateReferenceSystem.fromEpsgId(code) and QgsCoordinateReferenceSystem('EPSG:3857')

are functionally the same?

@agiudiceandrea please don't jump to conclusions, give us a nudge next time.

agiudiceandrea commented 3 years ago

please don't jump to conclusions, give us a nudge next time.

happy to have been proven wrong :-)

drf5n commented 3 years ago

Yes, they are functionally the same. You can pass a bare code to the fromEpsgId function, or you can prefix the code with "EPSG:" and it meas the same thing.

https://github.com/nextgis/quickmapservices/pull/204 fixes more deprecations, so it was better than this PR.