[ ] Implemented the source code change that satisfies the tests
[ ] Documented the feature by providing worked example
[ ] Updated the README or other documentation
[ ] Completed the pre-Request checklist below
Change Description
In the existing implementation of the Xios class, its write method accepts a C-style array of doubles, along with its dimensions in each direction. The approach adopted here - better in line with neXtSIM-DG's approach - is to instead pass a ModelArray, which knows about both the data and dimensions.
NOTE: #559 will need to be merged first.
Test Description
Updated the tests accordingly.
[x] Implement changes in XIOS integration test.
[ ] Fix linking/build for XIOS integration test.
Pre-Request Checklist
[x] The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
[ ] No new warnings are generated
[ ] The documentation has been updated (or an issue has been created to track the corresponding change)
[ ] Methods and Tests are commented such that they can be understood without having to obtain additional context
[ ] This PR/Issue is labelled as a bug/feature/enhancement/breaking change
[ ] File dates have been updated to reflect modification date
[ ] This change conforms to the conventions described in the README
Pass
ModelArray
toXios.write
, rather than array ofdouble
sFixes #544
Task List
Change Description
In the existing implementation of the
Xios
class, itswrite
method accepts a C-style array ofdouble
s, along with its dimensions in each direction. The approach adopted here - better in line with neXtSIM-DG's approach - is to instead pass aModelArray
, which knows about both the data and dimensions.NOTE: #559 will need to be merged first.
Test Description
Updated the tests accordingly.
Pre-Request Checklist