Open corneliusroemer opened 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.29%. Comparing base (
29188d4
) to head (27d18b4
). Report is 4 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This might be worth an internal changelog entry
Description of proposed changes
diff_jsons.py
when exclude-regex-path is used incorrectly like in issue 1665 to prevent this issue from reoccurring silently["root['generated_by']", "root['meta']['updated']"]
instead of["root['generated_by']['version']"]
. This allows simplification of a lot of invocations ofdiff_jsons.py
and in turn reduces chance of errors similar to issue 1665. Anything withingenerated_by
can be ignored by cram tests,meta.updated
is only used in export, but no harm excluding by default as it isn't used in any other tests. If there's opposition, happy to revert that change.Checklist