This was flawed: even though ci.yaml is called by another workflow, the github context is associated with the caller workflow so event_name is "workflow_dispatch" during a release run.
It doesn't make sense to update the condition to match "workflow_dispatch", since there are valid reasons for running ci.yaml using workflow_dispatch.
I think it makes more sense to simply remove this half of the condition as redundant. The other half of the condition sufficiently ensures that the job is run only when called by the release workflow on the default branch.
Description of proposed changes
This was flawed: even though ci.yaml is called by another workflow, the
githubcontext is associated with the caller workflow so event_name is "workflow_dispatch" during a release run.It doesn't make sense to update the condition to match "workflow_dispatch", since there are valid reasons for running ci.yaml using workflow_dispatch.
I think it makes more sense to simply remove this half of the condition as redundant. The other half of the condition sufficiently ensures that the job is run only when called by the release workflow on the default branch.
Related issue(s)
Fixes #1674
Checklist