Replace jest-puppeteer with Playwright - Githubissues

nextstrain / auspice

Web app for visualizing pathogen evolution

https://docs.nextstrain.org/projects/auspice/

GNU Affero General Public License v3.0

292 stars 162 forks source link

Replace jest-puppeteer with Playwright #1884

Closed victorlin closed 3 weeks ago

victorlin commented 3 weeks ago

Description of proposed changes

Advantages of the new Playwright setup:

It auto-detects whether a server is already running (no need for two separate npm scripts)
Browser installation is done in a separate command. Previously, it was done on installation of puppeteer which became difficult to debug when it timed out on remote build environments.
It requires much fewer dependencies (see diff of package-lock.json)

Related issue(s)

Hopefully resolves #1843. Even if it doesn't, the separate browser installation command should make it easier to debug/configure.

Checklist

[x] Checks pass
[x] ~If making user-facing changes, add a message in CHANGELOG.md summarizing the changes in this PR~
[x] ~(to be done by a Nextstrain team member) Create preview PRs on downstream repositories.~

victorlin commented 3 weeks ago

Jobs using npm ci without --ignore-scripts (build, smoke-test) now run in ~1m30s compared to the previous ~6m.