[bugfix] Restore shift-click branch behaviour

jameshadfield commented 2 weeks ago

Clicking a branch while holding the shift-key should show an info modal.

Bisecting indicates that this regression occurred via

25294e899be20256844e26cdfb5d6b550616b6eb is the first bad commit
commit 25294e899be20256844e26cdfb5d6b550616b6eb
Author: Victor Lin <13424970+victorlin@users.noreply.github.com>
Date:   Fri Oct 25 16:11:34 2024 -0700

    Properly check window.event.shiftKey

    Only KeyboardEvent has the shiftKey property.

 src/components/tree/reactD3Interface/callbacks.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(See #1900 for a somewhat related bug discovered while fixing this.)

jameshadfield commented 2 weeks ago

Merging sans review

victorlin commented 2 weeks ago

Only KeyboardEvent has the shiftKey property.

Man I was wrong. Should have tested this in #1864. Thanks for catching!

nextstrain / auspice

[bugfix] Restore shift-click branch behaviour #1901