search

nexusformat / NIAC

Issue for the NIAC to discuss (no code)
2 stars 0 forks source link

Protect main branch of repos #113

Closed PeterC-DLS closed 2 years ago

PeterC-DLS commented 2 years ago

Seems to be a sensible and standard thing to do

benajamin commented 2 years ago

Can you please describe what this means in some detail? I assume you mean to only allow a select group of github accounts to merge pull requests to main - is that correct? Would the authorised group be the project owners?

PeterC-DLS commented 2 years ago

No, I mean this about-protected-branches. So requirements such as CI checks can pass before a merge.

prjemian commented 2 years ago

This is a good protection that means any change to the main branch will come from a branch that passes testing.

prjemian commented 2 years ago

It also means that trivial changes (such as typos in the documentation) MUST go through a branch/fork & pull request process.

benajamin commented 2 years ago

Proposal is to authorise Peter Chang to protect the nexusformat repository main branches.

PeterC-DLS commented 2 years ago

Ok, I have protected the definitions repo's main branch so that

  1. a pull request is required before merging
  2. that PR needs 1 approval before merging
  3. status checks required to pass
  4. conversations on code in PR need resolving
  5. include admins in protection
  6. not require linear history (may want to change in future, my recommendation is to rebase when merging)