Closed Gigarrum closed 1 year ago
From Code Camp discussion:
Generally it's a matter for the individual application definitions and the communities that manage them.
@Gigarrum, if you would like further clarification to be incorporated into NXbeam, could you write the words you are thinking into a pull request that would close this issue? Otherwise, I'd say go ahead and close it if you are satisfied. Thanks for the questions!
@phyy-nx can you change the status of this issue to "Ready for Review", I don't have permissions to do so.
Done, and I've added #1283 to the project
According to NXbeam documentation the information inside the group refers to "properties of the neutron or X-ray beam at a given location" and that the group "is intented to be referenced by beamline component groups within the NXinstrument".
Considering that, I understand that a NXbeam group should be defined inside groups that define specific instrumentation (e.g: NXdetector, ) or that defines the sample (NXsample) defined in the documentation inside the NXsample, so it is possible to correctly know the position of the beam being defined.
However on NXmx application definition the NXbeam group is defined directly inside the NXinstrument group, that means it is being considered the same beam configuration over all devices? If yes, I would recommend adding this interpretation to docs on NXbeam otherwise NXmx application definition may need corrections.